Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compile installation for Debian/Ubuntu #2378

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Sep 9, 2024

No related issue, setting up a dev env for snapcraft helped me find the error

@jwrober jwrober requested a review from blabber September 9, 2024 16:52
Copy link
Collaborator

@blabber blabber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure: do you really need both, g++ and clang? One is the GNU C++ compiler, the other contains the clang C++ compiler. I'd expect that I e of them should be enough (probably clang).

Copy link
Collaborator

@blabber blabber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure: do you really need both, g++ and clang? One is the GNU C++ compiler, the other contains the clang C++ compiler. I'd expect that I e of them should be enough (probably clang).

Ah, I see. It's clang-format, not clang...

@jwrober
Copy link
Collaborator Author

jwrober commented Sep 9, 2024

We only add clang-format, not the compiler. Cmake will get gcc, but not g++ for some reason on Ubuntu 24.04

@jwrober jwrober merged commit 8dbc06d into longturn:master Sep 9, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants