Governor fixes #2301
Merged
Governor fixes #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is inefficient in terms of network traffic, but it means governors are saved immediately, which is usually what the user wants.
Every time the governor parameter were fetched, they would be deserialized from the attribute, then serialized again to the same values. Stop doing that.
This prevents sending multiple updates when every slider gets modified.
lmoureaux
force-pushed
the
bugfix/governor
branch
from
cc0ca56 to
2287f84
Compare
lmoureaux
force-pushed
the
bugfix/governor
branch
from
2287f84 to
ae12647
Compare
jwrober
approved these changes
Jul 1, 2024
|
Had to backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing some governor issues mentioned by TriClad.
Maybe will eventually address #1834