Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate Snap builds - Take 1 #2278

Merged
merged 14 commits into from
May 3, 2024
Merged

Automate Snap builds - Take 1 #2278

merged 14 commits into from
May 3, 2024

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Apr 13, 2024

Closes #2174

@jwrober jwrober marked this pull request as ready for review April 14, 2024 13:53
@jwrober jwrober requested a review from lmoureaux April 14, 2024 13:53
lmoureaux
lmoureaux reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few questions on how this will work in practice. In additions to the ones below, I'd like to make sure that the version number in the uploaded package will be correct.

.github/workflows/release.yaml Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
@jwrober jwrober requested a review from lmoureaux April 18, 2024 21:41
@jwrober
Copy link
Collaborator Author

jwrober commented Apr 18, 2024

@lmoureaux I think this is ready. Final review at your convenience.

@lmoureaux lmoureaux merged commit 064cac7 into longturn:master May 3, 2024
21 checks passed
@jwrober jwrober deleted the feature/auto-snaps branch May 3, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmoureaux lmoureaux lmoureaux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automate stable snap updates
2 participants
@jwrober @lmoureaux