Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gui theme dir #2202

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Remove gui theme dir #2202

merged 2 commits into from
Feb 14, 2024

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Feb 10, 2024

Closes #2172

@jwrober jwrober requested a review from lmoureaux February 10, 2024 17:48
lmoureaux
lmoureaux reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff has many changes seemingly unrelated with the PR. While they look ok (reordering headers to be more consistent), it would be better to have them in a separate commit (and possibly PR, but I can live with it).

@jwrober
Copy link
Collaborator Author

jwrober commented Feb 14, 2024

I cleaned lot of ref's to //gui-qt in the headers so that did create some noise.

@jwrober jwrober merged commit cbe265c into longturn:master Feb 14, 2024
21 checks passed
@jwrober jwrober deleted the remove-gui-theme-dir branch March 30, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmoureaux lmoureaux lmoureaux left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop gui-qt from themes path
2 participants
@jwrober @lmoureaux