Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring docs up to date with some gui changes #2180

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Jan 27, 2024

No related issue.

@jwrober jwrober requested a review from daavko January 27, 2024 20:00
Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the window decorations on the new screenshot there to make the Flatpak team happy? If so, the screenshot should also include the window shadow and be significantly smaller so it gets displayed at 1:1 on their website.

@jwrober
Copy link
Collaborator Author

jwrober commented Jan 28, 2024

I made this change before I was aware of the flathub business. I made it to make me happy, not them :)

@lmoureaux
Copy link
Contributor

I think it would make sense to make the screenshot smaller, I can't even display it at 1:1 on my screen. Let's take the Flathub dimensions as a guideline?

@jwrober
Copy link
Collaborator Author

jwrober commented Jan 30, 2024

I'm fine to make the image smaller. I don't like the dropshadow requirement tho.

@lmoureaux
Copy link
Contributor

lmoureaux commented Jan 30, 2024

I'm fine to make the image smaller. I don't like the dropshadow requirement tho.

Let's make it smaller without window decorations and if they're unhappy, explain that there is a conflict in their guidelines between "default configuration" (which is fullscreen) and "drop shadows". Since shadows are cosmetic, we choose to follow the configuration guideline.

@jwrober
Copy link
Collaborator Author

jwrober commented Jan 30, 2024

I'll retake the screen shot in full screen mode and resize following their guidelines on size and push another commit.

@jwrober jwrober requested a review from lmoureaux February 9, 2024 23:04
@jwrober jwrober merged commit 54406ae into longturn:master Feb 9, 2024
20 checks passed
@jwrober jwrober deleted the docs/update-2024-1 branch March 30, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants