Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "client" from the app name on Windows and in AppStream metadata #2171

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Remove "client" from the app name on Windows and in AppStream metadata #2171

merged 2 commits into from
Jan 22, 2024

Conversation

lmoureaux
Copy link
Contributor

There is no need to use such a technical term in user-facing text. This also removes any need for translation.

@lmoureaux
Windows: rename client shortcuts to "Freeciv21"
8552e4f 
Since this is the main entry point for the game, just use the game name.
@lmoureaux
Rename the client to "Freeciv21" in AppStream metadata
278a9d6 
This is the main entry point for the game, so let it use the game name without
an additional qualifier.
@lmoureaux lmoureaux requested a review from jwrober January 21, 2024 21:38
jwrober
jwrober approved these changes Jan 21, 2024
View reviewed changes
Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I actually think we might want to back port this and fix flathub to match. I had to do some hacks in stable flathub to get it to work there. Reason for backport is so we don't have to fix it later when 3.1 becomes new stable.

@lmoureaux
Copy link
Contributor Author

Oh the appstream-utils calls? We could backport to remove those, yes.

@lmoureaux lmoureaux added the back-port back-port candidate label Jan 22, 2024
@lmoureaux lmoureaux merged commit f38a9fd into longturn:master Jan 22, 2024
21 checks passed
@lmoureaux lmoureaux deleted the feature/remove-client-from-names branch January 22, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwrober jwrober jwrober approved these changes

Assignees

@lmoureaux lmoureaux

Labels
back-port back-port candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmoureaux @jwrober