Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Add Ons button to start screen that loads mp installer #2143

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Jan 7, 2024

Closes #1366

Part of #2136

@jwrober jwrober marked this pull request as ready for review January 7, 2024 16:45
@jwrober jwrober requested a review from lmoureaux January 7, 2024 16:45
Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows the modpack installer is optional. Should we make it mandatory?

client/fc_client.cpp Outdated Show resolved Hide resolved
@jwrober jwrober requested a review from lmoureaux January 8, 2024 21:54
@jwrober
Copy link
Collaborator Author

jwrober commented Jan 8, 2024

On Windows the modpack installer is optional. Should we make it mandatory?

Just noticed this. Yes I think it has to be now. I'll push another change.

@jwrober
Copy link
Collaborator Author

jwrober commented Jan 8, 2024

Turns out the GUI modpack, isn't optional - https://github.com/longturn/freeciv21/blob/master/tools/fcmp/CMakeLists.txt#L34 - the CLI version is so we are good.

Copy link
Contributor

@lmoureaux lmoureaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to rebrand the installer item as "developer tools" or so then

@jwrober jwrober merged commit d375eef into longturn:master Jan 9, 2024
21 checks passed
@jwrober jwrober deleted the feature/modpack-start branch March 30, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add modpack installer to Start Screen
2 participants