Fix and modernize listener<> #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit d1f50af broke the listener<> template in a subtle way: the destructor wouldn't remove listeners from the set because dynamic_cast to a derived type returns nullptr in a destructor. This caused a segfault upon saving map images. In order to solve both the warning that lead to the commit and the new bug, change the set of instances to hold listener<A>* instead of A*, and use dynamic_cast in invoke since the A objects are still valid there. While I was there, I changed invoke() to be a variadic template. It wasn't one because the code originally had to support C++03.
|
Backport required - or at least revert the equivalent of d1f50af in |
jwrober
approved these changes
Jan 6, 2024
I see these in FreeBSD too. This is nothing to worry about in my opinion. The cause is that macOS and FreeBSD use clang/LLVM as the default compiler. One could conditionalize the warning using something like this, I am not sure if it is worth it though: |
This simplifies the user interface and removes a clang warning about it being potentially uninitialized. See longturn#2139.
Further improving the code helped removing the warning. |
jwrober
approved these changes
Jan 8, 2024
lmoureaux
added a commit
that referenced
this pull request
Jan 20, 2024
This simplifies the user interface and removes a clang warning about it being potentially uninitialized. See #2139.
lmoureaux
added a commit
to lmoureaux/freeciv21
that referenced
this pull request
Mar 17, 2024
This simplifies the user interface and removes a clang warning about it being potentially uninitialized. See longturn#2139.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit d1f50af broke the listener<> template in a subtle way: the destructor wouldn't remove listeners from the set because dynamic_cast to a derived type returns nullptr in a destructor. This caused a segfault upon saving map images.
In order to solve both the warning that lead to the commit and the new bug, change the set of instances to hold listener* instead of A*, and use dynamic_cast in invoke since the A objects are still valid there.
While I was there, I changed invoke() to be a variadic template. It wasn't one because the code originally had to support C++03.