Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a weekly FreeBSD CI run #2101

Merged
merged 3 commits into from
Dec 30, 2023
Merged

Conversation

lmoureaux
Copy link
Contributor

This PR fixes build errors on FreeBSD and adds a weekly CI run to ensure it doesn't break in the future. While debugging FreeBSD, I understood the cause of the test errors on Fedora and also included a fix/workaround for that (FreeBSD got a different solution).

I did a full CI run in my local (before squashing debug commits into a nice history, but the code was identical)

There were some complications because the VM runs as a priviledged user and the
server is designed not to start in this case. So we need to create an
unpriviledged user to compile and run the tests.
Disable root user detection on Fedora so the test pass (the user in the Docker
image is root).
@lmoureaux lmoureaux requested a review from jwrober December 30, 2023 04:41
@lmoureaux lmoureaux marked this pull request as ready for review December 30, 2023 04:41
@lmoureaux lmoureaux mentioned this pull request Dec 30, 2023
Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jwrober jwrober merged commit 4070949 into longturn:master Dec 30, 2023
20 checks passed
@lmoureaux lmoureaux deleted the feature/freebsd branch January 8, 2024 10:55
@lmoureaux lmoureaux added the back-port back-port candidate label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-port back-port candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants