Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests with multi-config build generators #2098

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Fix tests with multi-config build generators #2098

merged 2 commits into from
Dec 30, 2023

Conversation

lmoureaux
Copy link
Contributor

And add a test for it!

@lmoureaux lmoureaux requested a review from jwrober December 29, 2023 19:28
@lmoureaux
Test multi-config CMake
ef2198d 
Use the "Additional compile flags" CI test to check that multi-config CMake
generators work.
@lmoureaux
Copy link
Contributor Author

The CI is green 🍏

@jwrober jwrober mentioned this pull request Dec 30, 2023
Merged
jwrober
jwrober approved these changes Dec 30, 2023
View reviewed changes
Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is a good next step. Still more work todo.

@jwrober jwrober merged commit 2a6ffa5 into longturn:master Dec 30, 2023
19 of 20 checks passed
@lmoureaux lmoureaux deleted the bugfix/multi-config branch December 30, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwrober jwrober jwrober approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmoureaux @jwrober