Load window icons from a custom icon theme #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The window icons used to be set by the tileset. This allowed user-made tilesets to override our branding and required loading tilesets before the first window was shown. This commit moves the app icons away from tilesets into a custom icon theme (this should eventually be merged into the hicolor theme). Closes longturn#984. Closes longturn#2019.
jwrober
requested changes
Dec 27, 2023
jwrober
pushed a commit
that referenced
this pull request
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The window icons used to be set by the tileset. This allowed user-made tilesets to override our branding and required loading tilesets before the first window was shown.
This commit moves the app icons away from tilesets into a custom icon theme (this should eventually be merged into the hicolor theme).
Closes #984.
Closes #2019.
Untested on Windows and Mac, but I tried to update all references to
misc/freeciv21-*.png.