Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dereference after null check in ratesdlg.cpp #2080

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Fix dereference after null check in ratesdlg.cpp #2080

merged 1 commit into from
Dec 25, 2023

Conversation

lmoureaux
Copy link
Contributor

Closes #2072.
Coverity CID 1528901.

This affects the national budget dialog when there is no player (global observer). I haven't been able to fire it up in this case, but better safe than sorry.

@lmoureaux lmoureaux requested a review from jwrober December 24, 2023 00:34
jwrober
jwrober approved these changes Dec 24, 2023
View reviewed changes
Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Works for me.

@lmoureaux lmoureaux merged commit b8bfe2b into longturn:master Dec 25, 2023
18 of 19 checks passed
@lmoureaux lmoureaux deleted the bugfix/deref-after-null-check branch December 25, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwrober jwrober jwrober approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coverity: Dereference after null check in ratesdlg.cpp
2 participants
@lmoureaux @jwrober