Update CMake files to use FindPython3 #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmoureaux
added
the
tools
|
Looks like I broke Windows. Apple failed for a different reason |
FindPythonInterp is deprectaed. FindPython3 is a drop-in replacement.
The replacement is not as drop-in as I thought. See PR longturn#2056.
lmoureaux
force-pushed
the
feature/update-cmake-find-python
branch
from
b13da4e to
9ab2dc7
Compare
|
I am going to run this on Windows clang to double check its ok there. |
|
Let me tune a few knobs so we can trigger this on Github |
Allows checking that everything builds when needed (e.g. when editing CMake code). See longturn#2056.
Full build starting here: https://github.com/lmoureaux/freeciv21/actions/runs/7012070710 |
Succeeded (except for macOS with the usual bug) |
jwrober
approved these changes
Nov 28, 2023
lmoureaux
added a commit
that referenced
this pull request
Nov 28, 2023
The replacement is not as drop-in as I thought. See PR #2056.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FindPythonInterp is deprectaed. FindPython3 is a drop-in replacement.