Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using the unit type for Shield2Gold_Factor #2030

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Allow using the unit type for Shield2Gold_Factor #2030

merged 1 commit into from
Dec 4, 2023

Conversation

lmoureaux
Copy link
Contributor

Closes #769.

Will want @Corbeau-1 to test the .exe once the Windows build is ready.

@lmoureaux lmoureaux requested a review from jwrober September 5, 2023 22:22
@jwrober
Copy link
Collaborator

jwrober commented Sep 5, 2023

If Corbeau says it works, then I will approve it.

@lmoureaux
Copy link
Contributor Author

I'm afraid we won't get a review by @Corbeau-1. Should we just merge?

jwrober
jwrober approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmoureaux lmoureaux merged commit 6999e31 into longturn:master Dec 4, 2023
@lmoureaux lmoureaux deleted the feature/utype-dependent-upkeep branch December 4, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwrober jwrober jwrober approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Shield2Gold_Factor to depend on the unit
2 participants
@lmoureaux @jwrober