Fix picking a gender and init randomly #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Picking a gender was not working because the radio buttons weren't synchronized with the internal variable holding the information. Discard the internal variable and use the buttons as the source of truth. Always make sure that one of the buttons is selected. Pick one randomly on startup, as choosing one would be offensive towards half of humankind. Reported by Hawk on Discord.
jwrober
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking a gender was not working because the radio buttons weren't synchronized with the internal variable holding the information. Discard the internal variable and use the buttons as the source of truth. Always make sure that one of the buttons is selected. Pick one randomly on startup, as choosing one would be offensive towards half of humankind.
Reported by Hawk on Discord.
Backport candidate.