Make nukes destroy infrastructure #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an effect Nuke_Infrastructure_Pct that allows the destruction of extras located within the blast area of nuclear weapons. Destroying infrastructure makes large-scale nuclear warfare more difficult because roads and rails need be rebuilt before tanks can ride them again to reach the next city. This is a rewrite of 8691fa8e38c56c6fa066c77aadf1eab1df5e620b in the 2.6 LT repo. Extras of category "Infra" can potentially be destroyed in nuclear blasts, with an effect-configurable chance. Contrary to the original commit, hidden extras can be blasted away just like they can be (target-)pillaged; this can be prevented with suitable rmreqs. See longturn#1155.
|
It's broken, I have a fix, will push once my Internet works again |
lmoureaux
force-pushed
the
feature/nukes
branch
from
8a0d731 to
33b1503
Compare
|
Code seems reasonable. How do I test this? |
|
See the Test plan above 😉 I used the tileset demo since it has a nuke ready to be fired |
|
LoL, oops. I didn't read carefully enough. |
|
Hi everyone, are we still re-inventing wheels? It seems so. I talked to other open-source people they said ... (?!!!?) Anyway, scared to talk here shut down last time for trying to get a consensus on fuel unit upgrade. |
|
obviously of course because nukes destroy infra first at FCW but the worst thing for all freeciv is if certain people do not meet minds, because you apparently think we can compete with $149M budget games |
|
If you want FCW features to be ported over to FC21, please open PRs and/or issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an effect Nuke_Infrastructure_Pct that allows the destruction of extras located within the blast area of nuclear weapons. Destroying infrastructure makes large-scale nuclear warfare more difficult because roads and rails need be rebuilt before tanks can ride them again to reach the next city.
This is a rewrite of 8691fa8e38c56c6fa066c77aadf1eab1df5e620b in the 2.6 LT repo. Extras of category "Infra" can potentially be destroyed in nuclear blasts, with an effect-configurable chance. Contrary to the original commit, hidden extras can be blasted away just like they can be (target-)pillaged; this can be prevented with suitable rmreqs.
See #1155.
Test Plan
Add the following to your fav ruleset and drop a nuke:
About half of the extras within the 3x3 blast radius should be gone (unless SDI went in action).