Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cancelling goto with ESC #1309

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Fix cancelling goto with ESC #1309

merged 2 commits into from
Aug 22, 2022

Conversation

lmoureaux
Copy link
Contributor

Closes #1086.

@lmoureaux lmoureaux requested a review from daavko August 22, 2022 01:22
daavko
daavko approved these changes Aug 22, 2022
View reviewed changes
Copy link
Collaborator

@daavko daavko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fixes the bug.

I don't feel comfortable doing code review on C++ code (yes, even for tiny changes), so that'll have to be done by someone else if it's required.

@lmoureaux lmoureaux merged commit db195f5 into longturn:master Aug 22, 2022
@lmoureaux lmoureaux deleted the bugfix/cancel-goto-esc branch August 22, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daavko daavko daavko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Esc to deactivate goto doesn't work
2 participants
@lmoureaux @daavko