Fix crash when non-player changes ai_manual_turn_done #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmoureaux
reviewed
Aug 17, 2022
client/options.cpp
Outdated
| if (can_end_turn()) { | ||
|
|
||
| if (!gui_options.ai_manual_turn_done) { | ||
| player *pplayer = client_player(); |
This could happen in pre-game, or for global observer. See osdn #45310 Ported from: freeciv/freeciv@a8570f3
psampathkumar
force-pushed
the
bugfix/ai_manual_turn_done
branch
from
17af757 to
9f7543a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could happen in pre-game, or for global observer.
See osdn #45310
Ported from: freeciv/freeciv@a8570f3