Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add two separators to the multiplayer menu #1261

Merged
merged 1 commit into from
Aug 13, 2022
Merged

Add two separators to the multiplayer menu #1261

merged 1 commit into from
Aug 13, 2022

Conversation

lmoureaux
Copy link
Contributor

This improves item grouping and thus usability.

See #1237.

@lmoureaux
Add two separators to the multiplayer menu
996731a 
This improves item grouping and thus usability.

See longturn#1237.
@lmoureaux lmoureaux requested a review from jwrober August 13, 2022 15:43
jwrober
jwrober approved these changes Aug 13, 2022
View reviewed changes
Copy link
Collaborator

@jwrober jwrober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks better. We still need to figure out what all to do with some of those menu entries. This however at least gives a break between the ones for warciv.

@lmoureaux lmoureaux enabled auto-merge (rebase) August 13, 2022 16:01
@lmoureaux lmoureaux merged commit ed330b6 into longturn:master Aug 13, 2022
@lmoureaux lmoureaux deleted the feature/multiplayer-menu-separators branch August 13, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwrober jwrober jwrober approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmoureaux @jwrober