Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Manual Update #1248

Merged
merged 9 commits into from
Aug 12, 2022
Merged

Client Manual Update #1248

merged 9 commits into from
Aug 12, 2022

Conversation

jwrober
Copy link
Collaborator

@jwrober jwrober commented Aug 11, 2022

No issue assigned. This is a collection of updates requested from the initial version of the manual.

@jwrober jwrober requested review from daavko and lmoureaux August 11, 2022 22:20
@jwrober
Copy link
Collaborator Author

jwrober commented Aug 11, 2022

Oh, the RTD build failed. It doesn't like the new extension. Hm...

@lmoureaux
Copy link
Contributor

Is it Github or did the image size actually increase?
image

@lmoureaux
Copy link
Contributor

Oh, the RTD build failed. It doesn't like the new extension. Hm...

https://docs.readthedocs.io/en/stable/config-file/v2.html#requirements-file

@jwrober
Copy link
Collaborator Author

jwrober commented Aug 11, 2022

Is it Github or did the image size actually increase?

Well it might have increased. I ran all the images through a compressor and didn't look at each one to see if there was any increases.

@jwrober
Copy link
Collaborator Author

jwrober commented Aug 11, 2022

Oh, the RTD build failed. It doesn't like the new extension. Hm...

https://docs.readthedocs.io/en/stable/config-file/v2.html#requirements-file

Ok. I'll look at this tomorrow

@jwrober
Copy link
Collaborator Author

jwrober commented Aug 12, 2022

Oh, the RTD build failed. It doesn't like the new extension. Hm...

https://docs.readthedocs.io/en/stable/config-file/v2.html#requirements-file

Ok. I'll look at this tomorrow

@lmoureaux i got it working -- see https://longturn--1248.org.readthedocs.build/en/1248/General/Manuals/client-manual.html to aid review

@lmoureaux
Copy link
Contributor

What's the difference between city-dialog-general-min.png and city-dialog-general.png?
Same question for city-dialog-min.png and city-dialog.png. For these, let's not introduce images with a buggy grid.

Please check that the compressed images are indeed smaller, otherwise you're making both the page and the repo heavier 😅

@jwrober
Copy link
Collaborator Author

jwrober commented Aug 12, 2022

What's the difference between city-dialog-general-min.png and city-dialog-general.png? Same question for city-dialog-min.png and city-dialog.png. For these, let's not introduce images with a buggy grid.

Please check that the compressed images are indeed smaller, otherwise you're making both the page and the repo heavier sweat_smile

Ok I messed up. I need to clean this up with another commit. I've got duplicate files on my hands now.

@jwrober jwrober merged commit 9e62e14 into longturn:master Aug 12, 2022
@jwrober jwrober deleted the docs/client-manual2 branch August 23, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants