Expand the city dialog text for wonders #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Far too many occurences to list: "citizen in this city" instead of "citizen of this city". |
lmoureaux
force-pushed
the
feature/max-happy-wonders
branch
from
3da57a3 to
dbbc77a
Compare
Done |
daavko
reviewed
Aug 8, 2022
lmoureaux
force-pushed
the
feature/max-happy-wonders
branch
from
dbbc77a to
5542476
Compare
Improve the description by explaining which effects are active and, for two of them, what contributes to their value (the third one is a simple binary effect, and that's harder to display properly). Helps longturn#269. Factor out a function to build such effect descriptions so we don't need to repeat the same code over and over again.
lmoureaux
force-pushed
the
feature/max-happy-wonders
branch
from
5542476 to
115b5a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the description by explaining which effects are active and, for two of
them, what contributes to their value (the third one is a simple binary effect,
and that's harder to display properly). Helps #269.
Factor out a function to build such effect descriptions so we don't need to
repeat the same code over and over again.
Granted, I wasn't very inspired when writing the default text.
With this PR, I'm happy to close #269, so:
Closes #269.