Allow implicit float to int conversions in sol2 #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolua was implicitly converting floats to ints, but sol2 chokes on this. For backward compatibility and to fix our own rulesets, disable this check in sol. Closes longturn#1161.
jwrober
approved these changes
Aug 1, 2022
|
It wasn't about building partisans, it was about generating them by conquering a city |
I observed partisans being generated via taking cities, so I think we are good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tolua was implicitly converting floats to ints, but sol2 chokes on this. For
backward compatibility and to fix our own rulesets, disable this check in sol.
Closes #1161.