Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc small refactorings #1170

Merged
merged 4 commits into from
Aug 1, 2022
Merged

Misc small refactorings #1170

merged 4 commits into from
Aug 1, 2022

Conversation

lmoureaux
Copy link
Contributor

Same as #1169 but at random locations (loosely related to the pregame code).

lmoureaux added 4 commits July 30, 2022 18:36
@lmoureaux
Clarify code in is_server_running()
386c7fd
@lmoureaux
Remove unused parameter in page_load::state_preview
f59a2b8
@lmoureaux
Merge all functions that pop down the city overlay
824e67d 
There were three functions that all did the same thing. Simplify the API by
merging them.
@lmoureaux
Remove useless queen() calls
6e00a03 
We were using queen()->mapview even from *inside* the map_view class.
Nonsense...
@lmoureaux lmoureaux added the refactoring This issue requires code refactoring label Jul 30, 2022
@lmoureaux lmoureaux requested a review from psampathkumar July 30, 2022 19:10
@psampathkumar psampathkumar merged commit 82c3123 into longturn:master Aug 1, 2022
@psampathkumar psampathkumar deleted the refactor/misc-small-refactorings branch August 1, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psampathkumar psampathkumar psampathkumar left review comments

Assignees
No one assigned
Labels
refactoring This issue requires code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmoureaux @psampathkumar