Don't try to set the ruleset based on the tileset #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes crashes less likely since no pointer is used.
lmoureaux
added
bug
The last used tileset was saved in the options file, but that value wasn't shown anywhere in the interface. It was then used *instead* of the tileset configured in the settings when the topology matched. This was a source of confusion. Get rid of this behavior by removing the hidden option.
The tileset in pregame isn't well defined because the topology isn't known yet. Always start servers with the default ruleset, and load a tileset based on that. If the user want to spawn a client with a given ruleset, they can use the -r option.
It's no longer supported.
lmoureaux
force-pushed
the
bugfix/hidden-tileset-changes-ruleset
branch
from
72ed772 to
f28c8c6
Compare
| bool first_boot; /* There was no earlier options saved. | ||
| * This affects some migrations, but not all. */ | ||
| char default_tileset_name[512]; // pre-2.6 had just this one tileset name | ||
| bool first_boot; /* There was no earlier options saved. |
There was a problem hiding this comment.
Why reformat comments ? :/
There was a problem hiding this comment.
Clang-format because it aligns them
There was a problem hiding this comment.
Argh, breaks git blame. But ok I guess.
psampathkumar
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last used tileset was saved in the options file, but that value wasn't shown anywhere in the interface. It was then used instead of the tileset configured in the settings when the topology matched. This was a source of confusion. Get rid of this behavior by removing the hidden option.
The tileset in pregame isn't well defined because the topology isn't known yet. Always start servers with the default ruleset, and load a tileset based on that.
If the user want to spawn a client with a given ruleset, they can use the
-roption.