Untested: Have Autorevision create a PR instead of trying to push #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Direct pushes to master are forbidden by branch protection rules. Have the automation create a PR instead, so we can approve it and enable automerge. It's a bit less convenient than a push but good enough for now. It also lets us check that the action is working is intended. If this works well, we could consider enabling automerge from within the action (or pushing directly as it looks like it's supported via an access token [1]). Closes longturn#955. [1] stefanzweifel/git-auto-commit-action#87
|
Does this mean that when we tag a release, the whole release process is paused until we approve of the PR and then once approved all the rest of the release process will continue including making the |
Source archive creation is not paused. I guess we should also run the autorevision updater before creating the tarball? Binary packages rely on the |
Don't rely one someone else having done it earlier, since the file only gets updated when the PR is merged. See longturn#1046.
jwrober
approved these changes
Jun 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct pushes to master are forbidden by branch protection rules. Have the
automation create a PR instead, so we can approve it and enable automerge. It's
a bit less convenient than a push but good enough for now. It also lets us
check that the action is working is intended. If this works well, we could
consider enabling automerge from within the action (or pushing directly as it
looks like it's supported via an access token [1]).
Closes #955.
[1] stefanzweifel/git-auto-commit-action#87