Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a button to show/hide the messages widget #1001 #1026

Merged
merged 1 commit into from
Jun 12, 2022
Merged

Add a button to show/hide the messages widget #1001 #1026

merged 1 commit into from
Jun 12, 2022

Conversation

NIKEA-SOFT
Copy link
Contributor

@NIKEA-SOFT NIKEA-SOFT commented Jun 11, 2022

Task from #1001

@lmoureaux
Copy link
Contributor

Simple change that improves the UI, I like it! Few comments:

  • Don't worry about the wasm build, it's not your fault
  • I can still move the messages using the small arrow at the top left. I think we should remove it.
  • The expand/collapse button in the title bar duplicates the new show/hide functionality in the top bar. I would also remove it.
  • The new icons won't follow the color scheme because they are in png format. With svg icons this code will automatically adjust the color (it's quite dumb: it replaces #000 everywhere in the file with another color). This way the icons can match the theme.
  • Speaking of icons, we should add .license files for the new files (look at data/themes/gui-qt/icons for examples)
  • Could we have a red dot on the notify icon? I think it would make it more distinct

@lmoureaux lmoureaux merged commit 87036ec into longturn:master Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants