Fix: server does not terminate the process #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmoureaux
reviewed
May 27, 2022
| @@ -21,6 +21,7 @@ | |||
|
|
|||
| // Qt | |||
| #include <QObject> | |||
| #include <atomic> | |||
There was a problem hiding this comment.
I don't think <atomic> is part of Qt... can we put an empty line between them?
There was a problem hiding this comment.
I don't think
<atomic>is part of Qt... can we put an empty line between them?
Why, if std::atomic is used there, we do not need to guess whether atomic is included somewhere or not
There was a problem hiding this comment.
I'm simply suggesting this:
// Qt
#include <QObject>
#include <atomic>So if in the future we include more of Qt or the STL, it doesn't become inconsistent.
|
Requesting a test from @jwrober -- start a local game, end it, the server should be gone |
jwrober
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server may not shutdown the process, it gets stuck in a loop, waiting for input to the console.