-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the gold indicator widget more informative #1000
Make the gold indicator widget more informative #1000
Conversation
The top bar widget that shows the current treasury and gold income gains two features: * It turns red when the income is negative. * Its outline turns red when low on funds. This should help newbies figure out when something is wrong. Closes longturn#983. Changes with respect to the proposed solution in the issue: * The whole text turns red when income is negative (for a technical reason), and * The global observer state is not implemented because the economy screen doesn't exist in that mode.
This prevents using it to reach the economics report, which is empty in global observer mode. The report can still be reached through its assigned shortcut (F5) or the Civilization menu.
34f4fae
to
0ce0b03
Compare
Is it possible to have the red outline "pulse" to help bring your eye to it? Red is hard on color blind folks, but that is ok. |
A custom style could do that, Qt stylesheets are too limited. I'm not sure a blinking widget in peripheral vision is a good idea, it would be too annoying.
It's not the only way to convey the information, though the minus sign occupies much less screen area. The contrast ratio with the background does fail Web accessibility standards... Color could be tweaked for better contrast. |
If we can go with a more contrasting color that meets web accessibility standards that would be ideal. |
The problem is actually the background, it's too bright to provide good contrast with anything but super washed out colors. Changing it would be going way overboard (NightStalker needs a complete revision if we want to meet the standards). |
Colors may not be optimal but work for the most part.
Implemented other themes. Didn't spend much time picking the perfect color, but tried to use something legible. |
The top bar widget that shows the current treasury and gold income gains two features:
This should help newbies figure out when something is wrong.
Closes #983.
Changes with respect to the proposed solution in the issue:
Only Nightstalker is implemented pending UI comments.
Screenshots of the new states: