Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the gold indicator widget more informative #1000

Merged
merged 3 commits into from
May 15, 2022

Conversation

lmoureaux
Copy link
Contributor

The top bar widget that shows the current treasury and gold income gains two features:

  • It turns red when the income is negative.
  • Its outline turns red when low on funds.

This should help newbies figure out when something is wrong.

Closes #983.
Changes with respect to the proposed solution in the issue:

  • The whole text turns red when income is negative (for a technical reason), and
  • The global observer state is not implemented because the economy screen doesn't exist in that mode.

Only Nightstalker is implemented pending UI comments.

Screenshots of the new states:

image
image

@lmoureaux lmoureaux requested review from jwrober and psampathkumar May 3, 2022 22:35
lmoureaux added 2 commits May 4, 2022 00:54
The top bar widget that shows the current treasury and gold income gains two features:

* It turns red when the income is negative.
* Its outline turns red when low on funds.

This should help newbies figure out when something is wrong.

Closes longturn#983.
Changes with respect to the proposed solution in the issue:

* The whole text turns red when income is negative (for a technical reason), and
* The global observer state is not implemented because the economy screen
  doesn't exist in that mode.
This prevents using it to reach the economics report, which is empty in global
observer mode. The report can still be reached through its assigned shortcut
(F5) or the Civilization menu.
@lmoureaux lmoureaux force-pushed the feature/polish-gold-indicator branch from 34f4fae to 0ce0b03 Compare May 3, 2022 22:54
@jwrober
Copy link
Collaborator

jwrober commented May 5, 2022

Is it possible to have the red outline "pulse" to help bring your eye to it? Red is hard on color blind folks, but that is ok.

@lmoureaux
Copy link
Contributor Author

Is it possible to have the red outline "pulse" to help bring your eye to it?

A custom style could do that, Qt stylesheets are too limited. I'm not sure a blinking widget in peripheral vision is a good idea, it would be too annoying.

Red is hard on color blind folks, but that is ok.

It's not the only way to convey the information, though the minus sign occupies much less screen area. The contrast ratio with the background does fail Web accessibility standards... Color could be tweaked for better contrast.

@jwrober
Copy link
Collaborator

jwrober commented May 5, 2022

If we can go with a more contrasting color that meets web accessibility standards that would be ideal.

@lmoureaux
Copy link
Contributor Author

The problem is actually the background, it's too bright to provide good contrast with anything but super washed out colors. Changing it would be going way overboard (NightStalker needs a complete revision if we want to meet the standards).

Colors may not be optimal but work for the most part.
@lmoureaux
Copy link
Contributor Author

Implemented other themes. Didn't spend much time picking the perfect color, but tried to use something legible.

@lmoureaux lmoureaux merged commit 1565124 into longturn:master May 15, 2022
@lmoureaux lmoureaux deleted the feature/polish-gold-indicator branch May 15, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polish top bar gold indicator
2 participants