New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the left side bar to a horizontal top bar #940

Closed

jwrober opened this issue Mar 16, 2022 · 0 comments · Fixed by #951

Labels

enhancement gui

Milestone

Collaborator

jwrober commented Mar 16, 2022 •

edited

Loading

Is your feature request related to a problem? Please describe.
Part of #750 -- Replace the left side bar to a more modern horizontal top bar that uses SVG graphics. Add toggle icons in upper right to hide/unhide or enable/disable the messages, server (chat) and mini-map widgets.

Describe the solution you'd like
Some sample mock up wireframes from a Discord conversation:

Clicking varying elements on the bar will bring up existing screens, widgets, or reports:

Nation Flag & Name [click opens player/nations dialog]
Turn # / Year
Population (using K, M modifiers to reduce numerals needed)
Number of Cities [click opens city dialog]
Current Government [click opens option to change gov't?]
Global Warming Chance
Nuclear Winter Change
Spaceship status [click opens spaceship dialog]
Culture Score (+ per turn increase) [click opens a widget giving more details?]
Gold (surplus/deficit) [click opens economy dialog]
Tax, Science and Lux Rates [click opens tax rates dialog]
Research Target (BPT / % Complete / Turn Complete) [click open research]
Units Pending Orders (Units Affected by UWT) [click opens dialog]
Toggle chat widget, toggle messages widget, toggle mini-map widget
Help menu
Amount of time to TC / Manual Turn Icon

Describe alternatives you've considered
Obviously it works as is, but the whole point is to modernize the client. Pretty much all the commercial 4x games out there are using this UI feature.

Additional context
None

jwrober added enhancement gui labels

jwrober added this to the v3.0-beta.2 milestone

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Move the sidebar to the top of the window

65a1e63

We decided that the contents of the sidebar would be shown above the map. Start
this change by moving the widget to the top.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Rename sidebar -> top_bar

ad03544

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Switch the top bar layout to horizontal mode

9fdf406

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Remove unused heightForWidth from the top_bar

3193fb4

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Rudimentary top bar implementation with QToolButton

73f0bb9

QToolButton seems a better fit because it already provides most of the options
we need. Maybe the top bar should become a fully-fledged QToolBar.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Replace custom "enabled" flag with the QWidget property

3584ce2

Simplifies the implementation.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Top bar: Use QToolButton's icon functionality

1318e50

Replace custom-drawn icons with a standard QToolButton feature. Now they're
even SVG-capable!

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Set the top_bar_widget size policy internally

eb4c51e

This simplifies the code a little.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Remove the empty space in the top bar

46f1917

We'll rethink the layout later; for now, simplify it.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Remove custom text processing in top_bar_widget

e1853a4

Simplifies the code.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Remove "hover" flag in top bar widgets

fbcc82a

It was used for a tiny graphical tweak of little importance.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Remove custom painting of the top bar background

4077ff9

Themes can use QSS if they want something special.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Make the blink effect work with QToolButton

4581e63

It's not perfect but we're not after perfection. It works.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Remove bool parameter to top bar "clicked" callbacks

c3ab427

It wasn't used, removing it simplifies the code.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Restore an indication of which tab is selected

57b84df

I'm not sure what this will become so I'm implementing an ugly placeholder that
does the job.  We may want to implement the switching with a set of mutually
exclusive QAction.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Don't set all top bar buttons to checkable

Some of them can only be clicked (e.g. End Turn).

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Restore the display of the current tax rates

22028ef

Use a specialized class instead of a special mode of top_bar_widget.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Restore the display of the "indicators"

5513d6a

Use a near-copy of tax_rates_widget instead of a special mode of
top_bar_widget.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Drop now-unused top_bar_widget::standard

f01b0de

Code cleanup after moving the functionality to separate classes.

See longturn#940.

lmoureaux mentioned this issue

Initial implementation of the top bar #951

Merged

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Move the sidebar to the top of the window

5b46499

We decided that the contents of the sidebar would be shown above the map. Start
this change by moving the widget to the top.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Rename sidebar -> top_bar

102b3fc

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Switch the top bar layout to horizontal mode

8b84fe8

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Remove unused heightForWidth from the top_bar

3e578d7

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Rudimentary top bar implementation with QToolButton

ed2b5d2

QToolButton seems a better fit because it already provides most of the options
we need. Maybe the top bar should become a fully-fledged QToolBar.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Replace custom "enabled" flag with the QWidget property

fcf68b7

Simplifies the implementation.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Top bar: Use QToolButton's icon functionality

8bbc0bf

Replace custom-drawn icons with a standard QToolButton feature. Now they're
even SVG-capable!

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Remove "hover" flag in top bar widgets

167257f

It was used for a tiny graphical tweak of little importance.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Remove custom painting of the top bar background

e8e8b53

Themes can use QSS if they want something special.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Make the blink effect work with QToolButton

aa5fe96

It's not perfect but we're not after perfection. It works.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Remove bool parameter to top bar "clicked" callbacks

38fdd34

It wasn't used, removing it simplifies the code.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Restore an indication of which tab is selected

bbcc7f8

I'm not sure what this will become so I'm implementing an ugly placeholder that
does the job.  We may want to implement the switching with a set of mutually
exclusive QAction.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Don't set all top bar buttons to checkable

71e3038

Some of them can only be clicked (e.g. End Turn).

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Restore the display of the current tax rates

d583b59

Use a specialized class instead of a special mode of top_bar_widget.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Restore the display of the "indicators"

639ec66

Use a near-copy of tax_rates_widget instead of a special mode of
top_bar_widget.

See longturn#940.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue


          Drop now-unused top_bar_widget::standard

60a35e4

Code cleanup after moving the functionality to separate classes.

See longturn#940.

jwrober closed this as completed in #951

jwrober pushed a commit that referenced this issue


          Move the sidebar to the top of the window

dc53006

We decided that the contents of the sidebar would be shown above the map. Start
this change by moving the widget to the top.

See #940.

jwrober pushed a commit that referenced this issue


          Rename sidebar -> top_bar

893d8c5

See #940.

jwrober pushed a commit that referenced this issue


          Switch the top bar layout to horizontal mode

7eefd8b

See #940.

jwrober pushed a commit that referenced this issue


          Remove unused heightForWidth from the top_bar

c0b0a53

See #940.

jwrober pushed a commit that referenced this issue


          Rudimentary top bar implementation with QToolButton

QToolButton seems a better fit because it already provides most of the options
we need. Maybe the top bar should become a fully-fledged QToolBar.

See #940.

jwrober pushed a commit that referenced this issue


          Replace custom "enabled" flag with the QWidget property

35092ca

Simplifies the implementation.

See #940.

jwrober pushed a commit that referenced this issue


          Top bar: Use QToolButton's icon functionality

81e90cc

Replace custom-drawn icons with a standard QToolButton feature. Now they're
even SVG-capable!

See #940.

jwrober pushed a commit that referenced this issue


          Set the top_bar_widget size policy internally

9cd91a0

This simplifies the code a little.

See #940.

jwrober pushed a commit that referenced this issue


          Remove the empty space in the top bar

ebea180

We'll rethink the layout later; for now, simplify it.

See #940.

jwrober pushed a commit that referenced this issue


          Remove custom text processing in top_bar_widget

7e8095a

Simplifies the code.

See #940.

jwrober pushed a commit that referenced this issue


          Remove "hover" flag in top bar widgets

3ae0d6f

It was used for a tiny graphical tweak of little importance.

See #940.

jwrober pushed a commit that referenced this issue


          Remove custom painting of the top bar background

b48d2a9

Themes can use QSS if they want something special.

See #940.

jwrober pushed a commit that referenced this issue


          Make the blink effect work with QToolButton

e865bf5

It's not perfect but we're not after perfection. It works.

See #940.

jwrober pushed a commit that referenced this issue


          Remove bool parameter to top bar "clicked" callbacks

0fb9805

It wasn't used, removing it simplifies the code.

See #940.

jwrober pushed a commit that referenced this issue


          Restore an indication of which tab is selected

e462099

I'm not sure what this will become so I'm implementing an ugly placeholder that
does the job.  We may want to implement the switching with a set of mutually
exclusive QAction.

See #940.

jwrober pushed a commit that referenced this issue


          Don't set all top bar buttons to checkable

6fbd37e

Some of them can only be clicked (e.g. End Turn).

See #940.

jwrober pushed a commit that referenced this issue


          Restore the display of the current tax rates

17f676e

Use a specialized class instead of a special mode of top_bar_widget.

See #940.

jwrober pushed a commit that referenced this issue


          Restore the display of the "indicators"

a7e72fe

Use a near-copy of tax_rates_widget instead of a special mode of
top_bar_widget.

See #940.

jwrober pushed a commit that referenced this issue


          Drop now-unused top_bar_widget::standard

f8778e6

Code cleanup after moving the functionality to separate classes.

See #940.

lmoureaux mentioned this issue

Polish top bar gold indicator #983

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment