Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disbanding units via right click in city isn't working #819

Closed
lmoureaux opened this issue Jan 11, 2022 · 1 comment · Fixed by #862
Closed

Disbanding units via right click in city isn't working #819

lmoureaux opened this issue Jan 11, 2022 · 1 comment · Fixed by #862
Assignees
@lmoureaux
Labels
bug Something isn't working gui This issue requires changes to the user interface
Milestone
v3.0-beta.1

Comments

@lmoureaux
Copy link
Contributor

Describe the bug

@Corbeau-1 on Discord:

Disbanding units from in-city (right-click) isn't working.

To Reproduce
Steps to reproduce the behavior:

  1. See above

Expected behavior

Works

Platform and version (please complete the following information):

  • OS: Windows 10
  • Freeciv21 version: 3.0-alpha9
  • Ruleset/Longturn game (if applicable): SIM30Test
@lmoureaux lmoureaux added bug Something isn't working Untriaged This issue or PR needs triaging labels Jan 11, 2022
@jwrober jwrober added the gui This issue requires changes to the user interface label Jan 23, 2022
@jwrober jwrober added this to the v3.0-beta.2 milestone Jan 25, 2022
@lmoureaux
Copy link
Contributor Author

In fact, I don't get the context menu at all.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Jan 31, 2022
@lmoureaux
Fix performing actions from the city screen
e9095f9 
The condition in most if(can_issue_orders()) was reversed.
Closes longturn#819.
@lmoureaux lmoureaux removed the Untriaged This issue or PR needs triaging label Jan 31, 2022
@lmoureaux lmoureaux modified the milestones: v3.0-beta.2, v3.0-beta.1 Jan 31, 2022
@lmoureaux lmoureaux self-assigned this Jan 31, 2022
@lmoureaux lmoureaux mentioned this issue Jan 31, 2022
Merged
lmoureaux added a commit that referenced this issue Feb 5, 2022
@lmoureaux
Fix performing actions from the city screen
29efe22 
The condition in most if(can_issue_orders()) was reversed.
Closes #819.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmoureaux lmoureaux

Labels
bug Something isn't working gui This issue requires changes to the user interface
Projects
None yet
Milestone
v3.0-beta.1
Development

Successfully merging a pull request may close this issue.

Fix performing actions from the city screen lmoureaux/freeciv21
2 participants
@lmoureaux @jwrober