Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow moving panel handles out of the screen #751

Closed
lmoureaux opened this issue Nov 25, 2021 · 0 comments · Fixed by #752
Closed

Don't allow moving panel handles out of the screen #751

lmoureaux opened this issue Nov 25, 2021 · 0 comments · Fixed by #752
Labels
bug Something isn't working
Milestone
v3.0-beta.1

Comments

@lmoureaux
Copy link
Contributor

Describe the bug
When a panel handle is moved out of the screen, there's no way to move the panel.

To Reproduce
Steps to reproduce the behavior:

  1. Start a game
  2. Move the messages panel out of the screen
  3. Try to move it back

Expected behavior
Moving the handle out of the screen shouldn't be possible. Another case to consider is resizing the window.

Screenshots
image

Platform and version (please complete the following information):

  • OS: any
  • Freeciv21 version: 3.0-alpha9
  • Ruleset/Longturn game (if applicable): any
@lmoureaux lmoureaux added the bug Something isn't working label Nov 25, 2021
@lmoureaux lmoureaux added this to the v3.0-beta.1 milestone Nov 25, 2021
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Nov 27, 2021
@lmoureaux
Prevent moving widgets out of the window with move_widget
cd54e39 
Affects the chat, quick stats, unit info widgets.

See longturn#751.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Nov 27, 2021
@lmoureaux
Prevent moving the minimap out of the window
35d2e0d 
Closes longturn#751.
@lmoureaux lmoureaux mentioned this issue Nov 27, 2021
Merged
lmoureaux added a commit that referenced this issue Dec 3, 2021
@lmoureaux
Prevent moving widgets out of the window with move_widget
1c12622 
Affects the chat, quick stats, unit info widgets.

See #751.
lmoureaux added a commit that referenced this issue Dec 3, 2021
@lmoureaux
Prevent moving the minimap out of the window
d0e9eb3 
Closes #751.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v3.0-beta.1
Development

Successfully merging a pull request may close this issue.

Prevent moving panels out of sight lmoureaux/freeciv21
1 participant
@lmoureaux