Unit Cycling stops after saving

[HansLemurson]

Describe the bug
After I save a game and hear a windows chime sound, units no longer auto-cycle to the next available unit (pressing 'wait' does still work, though) and the menus for Diplomats no longer appear (cannot bribe a unit).

To Reproduce
Steps to reproduce the behavior:
Play game, units cycle as normal.
Save game (overwriting an old file)
Unit no longer cycle correctly, Diplomat menus stop showing up.

Closing and restarting the program resolves the issue.

Edit: Annoyingly, I can no longer seem to reproduce this bug after having quit and restarted the program several times.

Expected behavior
No weird stuff caused by extra windows appearing and vanishing.

Screenshots
How do you take a picture of something that does not happen?

Platform and version (please complete the following information):

• OS: Windows 10
• Freeciv21 version: 3.0-alpha7
• Ruleset: classic

Additional context
I think it might have to do with some effect from the file-system window that appears when you save a game. Maybe the "file over-write confirmation" popup?

[lmoureaux]

Can't reproduce in a new game on Linux, but I think I saw something similar once. But clicking on a unit restarted things as normal...

[HansLemurson]

How fitting that such a finicky bug is issue #666

[lmoureaux]

Postponing because I can't figure out how to reproduce.

[lmoureaux]

Unless we can figure out how to reproduce this I don't think it's worth keeping the issue open. Hopefully when it resurfaces we get repro steps.

[lmoureaux]

I think I managed to reproduce this issue in a game I'm currently playing. The symptoms are:

• Diplomat (and similar) dialogs stop popping up
• Workers remain selected after being assigned a task (e.g. irrigation)
• Some city management actions also appear broken

Reloading the game solves the problem for a while. @HansLemurson does that match what you were seeing?

First thought is that the request ID in the network protocol gets messed up somehow, but I didn't confirm it.

[HansLemurson]

I think I managed to reproduce this issue in a game I'm currently playing. The symptoms are:

• Diplomat (and similar) dialogs stop popping up
• Workers remain selected after being assigned a task (e.g. irrigation)
• Some city management actions also appear broken

Reloading the game solves the problem for a while. @HansLemurson does that match what you were seeing?

First thought is that the request ID in the network protocol gets messed up somehow, but I didn't confirm it.

Yes, that sounds about right!
What was the trigger?