Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Help dialog is too small by default #563

Closed
lmoureaux opened this issue Jul 25, 2021 · 0 comments · Fixed by #692
Closed

The Help dialog is too small by default #563

lmoureaux opened this issue Jul 25, 2021 · 0 comments · Fixed by #692
Assignees
@lmoureaux
Labels
bug Something isn't working gui This issue requires changes to the user interface

Comments

@lmoureaux
Copy link
Contributor

lmoureaux commented Jul 25, 2021 •
edited
Loading

Describe the bug

The Help dialog opens by default at a very small size. It could be adaptative and occupy maybe 2/3 of the available by default.

To Reproduce
Steps to reproduce the behavior:

  1. Remove ~/.config/freeciv21-client.ini
  2. Open the client
  3. Start a game
  4. Open Help > Terrain
  5. Navigate to Hills
  6. Watch the content as reproduced above

Expected behavior

The help dialog has a sensible default size.

Screenshots
image

Platform and version (please complete the following information):

  • OS: Kde Neon user
  • Freeciv21 version: be54cb4
  • Ruleset/Longturn game (if applicable): most, classic or LTEx24 will do

Additional context

The default size was chosen when 1024x768 resolution was still a thing and the Freeciv guidelines even recommended testing on 768x480.
@lmoureaux lmoureaux added bug Something isn't working gui This issue requires changes to the user interface labels Jul 25, 2021
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Oct 16, 2021
@lmoureaux
Open the help dialog with at least 1280*800px
b53d877 
This will enhances its layout on very busy pages (e.g. terrain and units).

Closes longturn#563.
@lmoureaux lmoureaux mentioned this issue Oct 16, 2021
Merged
@lmoureaux lmoureaux self-assigned this Oct 16, 2021
lmoureaux added a commit that referenced this issue Oct 27, 2021
@lmoureaux
Open the help dialog with at least 1280*800px
88259e6 
This will enhances its layout on very busy pages (e.g. terrain and units).

Closes #563.
psampathkumar pushed a commit to psampathkumar/freeciv21 that referenced this issue Nov 14, 2021
@lmoureaux @psampathkumar
Open the help dialog with at least 1280*800px
e8cfc9f 
This will enhances its layout on very busy pages (e.g. terrain and units).

Closes longturn#563.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmoureaux lmoureaux

Labels
bug Something isn't working gui This issue requires changes to the user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Open the help dialog with at least 1280*800px lmoureaux/freeciv21
1 participant
@lmoureaux