Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting to square games gives hex tiles #2441

Closed
lmoureaux opened this issue Nov 7, 2024 · 2 comments · Fixed by #2442
Closed

Connecting to square games gives hex tiles #2441

lmoureaux opened this issue Nov 7, 2024 · 2 comments · Fixed by #2442
Labels
bug Something isn't working gui This issue requires changes to the user interface important This issue should be fixed asap
Milestone

Comments

@lmoureaux
Copy link
Contributor

Describe the bug
Connecting to a game using square tiles may load a hex tileset

To Reproduce
Steps to reproduce the behavior:

  1. Move your config folder
  2. Start the game
  3. Connect to a running game with isometric square tiles
  4. hexemplio is used

Expected behavior
amplio2 is used

Platform and version (please complete the following information):

  • OS: Linux
  • Freeciv21 version: 3.1-rc.1
  • Ruleset/Longturn game (if applicable): classic

Additional context
Reported by Blauwal on Discord after updating his snap to 3.1-rc1, confirmed locally.

@lmoureaux lmoureaux added bug Something isn't working gui This issue requires changes to the user interface important This issue should be fixed asap labels Nov 7, 2024
@lmoureaux lmoureaux added this to the v3.1-stable milestone Nov 7, 2024
@lmoureaux
Copy link
Contributor Author

Produced config:

default_tileset_square_name=""
default_tileset_hex_name=""
default_tileset_isohex_name=""

@lmoureaux
Copy link
Contributor Author

The issue is that fill_topo_ts_default doesn't actually fill tileset options and we end up with hexemplio loaded.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Nov 8, 2024
The default tilesets were not set when starting the game for the first
time. This resulted in hexemplio being used regardless of the game
topology.

Closes longturn#2441.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gui This issue requires changes to the user interface important This issue should be fixed asap
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant