Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not a bug but hurtful behaviour: Don't move unit right away when X is pressed #2303

Closed
hugomflavio opened this issue Jun 15, 2024 · 2 comments · Fixed by #2315
Closed

Not a bug but hurtful behaviour: Don't move unit right away when X is pressed #2303

hugomflavio opened this issue Jun 15, 2024 · 2 comments · Fixed by #2315
Labels
bug Something isn't working gui This issue requires changes to the user interface

Comments

@hugomflavio
Copy link
Contributor

Describe the bug
Accidentally pressing X with a unit selected will send that unit running away immediately.

Preferred behavior
Since X is not commonly used, changing the behaviour so there's a pop-up to confirm, or so that the X unit only moves at the end of the turn (like auto-workers do), would give the player time to correct the order in the event of a mistake.
@hugomflavio hugomflavio added bug Something isn't working Untriaged This issue or PR needs triaging labels Jun 15, 2024
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Jul 7, 2024
@lmoureaux
Change the default autoexplore shortcut to Shift+X
11647c3 
This reduces the risk of hitting it by accident.

Closes longturn#2303.
@lmoureaux lmoureaux mentioned this issue Jul 7, 2024
Merged
@lmoureaux lmoureaux added gui This issue requires changes to the user interface and removed Untriaged This issue or PR needs triaging labels Jul 7, 2024
@lmoureaux
Copy link
Contributor

Went for the much easier fix of changing the default shortcut to Shift+X

@hugomflavio
Copy link
Contributor Author

Oooh that's actually awesome! Nice!

jwrober pushed a commit that referenced this issue Jul 8, 2024
@lmoureaux @jwrober
Change the default autoexplore shortcut to Shift+X
f0189e5 
This reduces the risk of hitting it by accident.

Closes #2303.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working gui This issue requires changes to the user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change the default autoexplore shortcut to Shift+X lmoureaux/freeciv21
2 participants
@lmoureaux @hugomflavio