Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The sorting order in Nations tab Team column should be natural, not alphabetical #2050

Closed
wsfsbvchr opened this issue Oct 28, 2023 · 2 comments · Fixed by #2082
Closed

The sorting order in Nations tab Team column should be natural, not alphabetical #2050

wsfsbvchr opened this issue Oct 28, 2023 · 2 comments · Fixed by #2082
Labels
bug Something isn't working gui This issue requires changes to the user interface

Comments

@wsfsbvchr
Copy link

Describe the bug
The team numbers of nations are sorted alphabetically.

To Reproduce
Steps to reproduce the behavior:

  1. Open a game with 10+ teams
  2. Click on the Team column in the Nations tab
  3. See the teams sorted alphabetically

Expected behavior
The teams numbers should be sorted naturally.

Screenshots
fc21-teams

Platform and version (please complete the following information):

  • OS: Linux
  • Freeciv21 version: 3.0.102624.1-patch
@wsfsbvchr wsfsbvchr added bug Something isn't working Untriaged This issue or PR needs triaging labels Oct 28, 2023
@jwrober jwrober added gui This issue requires changes to the user interface and removed Untriaged This issue or PR needs triaging labels Oct 28, 2023
@jwrober
Copy link
Collaborator

jwrober commented Oct 28, 2023

Thanks for the submission.

@lmoureaux
Copy link
Contributor

lmoureaux commented Nov 27, 2023 •
edited
Loading

QCollator supports this

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Dec 24, 2023
@lmoureaux
Enable natural sort in the nations view
313c2f6 
Closes longturn#2050.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Dec 24, 2023
@lmoureaux
Enable natural sort in the nations view
f1d10c1 
Closes longturn#2050.
@lmoureaux lmoureaux mentioned this issue Dec 24, 2023
Merged
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Dec 24, 2023
@lmoureaux
Enable natural sort in the nations view
fd8e41d 
Closes longturn#2050.
lmoureaux added a commit that referenced this issue Dec 25, 2023
@lmoureaux
Enable natural sort in the nations view
baf589e 
Closes #2050.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working gui This issue requires changes to the user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable natural sort in the nations view lmoureaux/freeciv21
3 participants
@lmoureaux @jwrober @wsfsbvchr