Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Government shouldn't be chosen randomly when losing a tech #2047

Closed
daavko opened this issue Oct 22, 2023 · 3 comments · Fixed by #2085
Closed

Government shouldn't be chosen randomly when losing a tech #2047

daavko opened this issue Oct 22, 2023 · 3 comments · Fixed by #2085
Labels
enhancement New feature or request server This issue requires changes to the server

Comments

@daavko
Copy link
Collaborator

daavko commented Oct 22, 2023

Is your feature request related to a problem? Please describe.
When a player loses a tech that causes them to lose access to a government, the game currently chooses a random available government. This may be surprising behavior to players, considering other situations that cause spontaneous government change would go directly to Anarchy instead.

Describe the solution you'd like
The game should go to Anarchy instead of randomly choosing.

Describe alternatives you've considered
Leaving it as-is, which is not great. Also considered leaving it up to ruleset author, but that'd be complicated since they'd have to make sure the player can go to the configured government in any situation where they'd lose a tech.

Additional context
Discord discussion https://discord.com/channels/378908274113904641/402213035865014272/1165650726400294932

@daavko daavko added enhancement New feature or request Untriaged This issue or PR needs triaging labels Oct 22, 2023
@lmoureaux
Copy link
Contributor

Since you've obviously researched this, would you have a link to the code location?

@lmoureaux
Copy link
Contributor

Thanks!

@lmoureaux lmoureaux added server This issue requires changes to the server and removed Untriaged This issue or PR needs triaging labels Dec 25, 2023
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Dec 25, 2023
When the technology for the current government is lost, the game used to pick
some government at random. Be more punitive and always switch to Anarchy. This
is more consistent with other government changes.

Closes longturn#2047.
jwrober pushed a commit that referenced this issue Dec 29, 2023
When the technology for the current government is lost, the game used to pick
some government at random. Be more punitive and always switch to Anarchy. This
is more consistent with other government changes.

Closes #2047.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request server This issue requires changes to the server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants