Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server does not update transport ship cargo status #1883

Closed
jwrober opened this issue Mar 27, 2023 · 0 comments · Fixed by #1889
Closed

Server does not update transport ship cargo status #1883

jwrober opened this issue Mar 27, 2023 · 0 comments · Fixed by #1889
Labels
bug Something isn't working gui This issue requires changes to the user interface server This issue requires changes to the server

Comments

@jwrober
Copy link
Collaborator

jwrober commented Mar 27, 2023

Describe the bug
If you have foreign units on one of your transport ships (e.g. a Galleon) and they disembark/alight and empty the ship, the game still shows the plus ( + ) icon showing they are loaded.

To Reproduce
Steps to reproduce the behavior:

  1. Load a game w/ allies (or a team game)
  2. Load foreign units onto a transporter
  3. Unload units from transporter
  4. See error

Expected behavior
The server needs to update the game with proper status.

Screenshots
image

Platform and version (please complete the following information):

  • OS: Linux
  • Freeciv21 version: 3.1-dev
  • Ruleset/Longturn game (if applicable): N/A

Additional context
Add any other context about the problem here.
@jwrober jwrober added bug Something isn't working gui This issue requires changes to the user interface server This issue requires changes to the server labels Mar 27, 2023
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Apr 3, 2023
@lmoureaux
Fix updating the old transport when switching ships
f5aad29 
The old transporter needs to be updated when a transported unit switches to
another transport, otherwise its "loaded" status may be wrong on the client
side.

Closes longturn#1883.
@lmoureaux lmoureaux mentioned this issue Apr 3, 2023
Merged
jwrober pushed a commit that referenced this issue Apr 3, 2023
@lmoureaux @jwrober
Fix updating the old transport when switching ships
039b957 
The old transporter needs to be updated when a transported unit switches to
another transport, otherwise its "loaded" status may be wrong on the client
side.

Closes #1883.
lmoureaux added a commit that referenced this issue Jun 17, 2023
@lmoureaux
Fix updating the old transport when switching ships
190e0bd 
The old transporter needs to be updated when a transported unit switches to
another transport, otherwise its "loaded" status may be wrong on the client
side.

Closes #1883.

(cherry picked from commit 039b957)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working gui This issue requires changes to the user interface server This issue requires changes to the server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix updating the old transport when switching ships lmoureaux/freeciv21
1 participant
@jwrober