Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pillaging doesn't start when using shortcut or unit actions widget button #1849

Closed
daavko opened this issue Mar 3, 2023 · 1 comment · Fixed by #1890
Closed

Pillaging doesn't start when using shortcut or unit actions widget button #1849

daavko opened this issue Mar 3, 2023 · 1 comment · Fixed by #1890
Labels
bug Something isn't working gui This issue requires changes to the user interface

Comments

@daavko
Copy link
Collaborator

daavko commented Mar 3, 2023

Describe the bug
When using the Shift+P shortcut or clicking the "Pillage" button in the unit actions widget at the bottom, nothing happens. Pillaging only works when clicking Combat > Pillage.

To Reproduce
Steps to reproduce the behavior:

  1. Have a unit that can pillage on a tile where there's something to pillage
  2. Use the Shift+P shortcut
  3. Observe nothing happens
  4. Click the "Pillage" button in the unit actions widget at the bottom
  5. Observe nothing happens
  6. Use Combat > Pillage
  7. Observe unit starts to pillage

Expected behavior
All ways to pillage should work

Screenshots
No screenshots

Platform and version (please complete the following information):

  • OS: Windows 10
  • Freeciv21 version: rc2 and latest master
  • Ruleset/Longturn game (if applicable): LT76

Additional context
No additional context
@daavko daavko added bug Something isn't working Untriaged This issue or PR needs triaging labels Mar 3, 2023
@daavko daavko changed the title Pillaging doesn't do anything when using shortcut or unit actions widget Pillaging doesn't start when using shortcut or unit actions widget button Mar 3, 2023
@jwrober jwrober added gui This issue requires changes to the user interface and removed Untriaged This issue or PR needs triaging labels Mar 3, 2023
@jwrober
Copy link
Collaborator

jwrober commented Mar 3, 2023

I can recreate

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Apr 3, 2023
@lmoureaux
Fix pillaging shortcuts (Shift+P, unit control bar)
2b46680 
Requested by French rioters.

Closes longturn#1849.
@lmoureaux lmoureaux mentioned this issue Apr 3, 2023
Merged
jwrober pushed a commit that referenced this issue Apr 5, 2023
@lmoureaux @jwrober
Fix pillaging shortcuts (Shift+P, unit control bar)
0492b96 
Requested by French rioters.

Closes #1849.
lmoureaux added a commit that referenced this issue Jun 17, 2023
@lmoureaux
Fix pillaging shortcuts (Shift+P, unit control bar)
67a1d90 
Requested by French rioters.

Closes #1849.

(cherry picked from commit 0492b96)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working gui This issue requires changes to the user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pillaging shortcuts (Shift+P, unit control bar) lmoureaux/freeciv21
2 participants
@daavko @jwrober