Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rush buying a unit shows complete in 2 turns #1848

Closed
jwrober opened this issue Mar 3, 2023 · 1 comment · Fixed by #2090
Closed

Rush buying a unit shows complete in 2 turns #1848

jwrober opened this issue Mar 3, 2023 · 1 comment · Fixed by #2090
Labels
bug Something isn't working gui This issue requires changes to the user interface

Comments

@jwrober
Copy link
Collaborator

jwrober commented Mar 3, 2023

Describe the bug
Not always, there is some condition that occurs that when you rush buy a unit the client will show 2 turns to finish and zero gold. The unit is finished at turn change as expected, but the city dialog shows an incorrect value.

To Reproduce
Steps to reproduce the behavior:

  1. Open a game
  2. Open a city building a unit such as a Caravan
  3. Rush buy the unit
  4. See error -- note that it does not happen at all times

Expected behavior
The city dialog shows correct values

Screenshots
image

Platform and version (please complete the following information):

  • OS: Linux
  • Freeciv21 version: 3.1-dev, and in 3.0-rc.2
  • Ruleset/Longturn game (if applicable): Discovered in LTX LT76Teams, so don't know if its a rules thing or a client thing for sure.

Additional context
Add any other context about the problem here.

@jwrober jwrober added bug Something isn't working gui This issue requires changes to the user interface labels Mar 3, 2023
@lmoureaux
Copy link
Contributor

To be more specific, it shows the number of turns to completion before buying, as if the client was unaware of the gold it spent.

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Dec 27, 2023
The client's accounting of the shield stock didn't always take the bought
shields into account.

Closes longturn#1848.
lmoureaux added a commit that referenced this issue Dec 27, 2023
The client's accounting of the shield stock didn't always take the bought
shields into account.

Closes #1848.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gui This issue requires changes to the user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants