Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using the keyboard shortcut for showing/hiding the map while in city view makes the map widget an incorrect size #1126

Closed
daavko opened this issue Jul 13, 2022 · 1 comment · Fixed by #1325
Closed

Using the keyboard shortcut for showing/hiding the map while in city view makes the map widget an incorrect size #1126

daavko opened this issue Jul 13, 2022 · 1 comment · Fixed by #1325
Labels
bug Something isn't working gui This issue requires changes to the user interface

Comments

@daavko
Copy link
Collaborator

daavko commented Jul 13, 2022

Describe the bug
When you show/hide the map while in city view, the containing widget retains the size it had before, instead of resizing correctly.

To Reproduce
Steps to reproduce the behavior:

  1. Open any city view
  2. Show or hide the map
  3. Close the city view
  4. Observe the map widget is incorrect size

Expected behavior
The widget should size itself according to the current contents

Screenshots
Map widget after getting shown when in city view (very vertically squished):
6Cta0t65XH

Platform and version (please complete the following information):

  • OS: Windows 10
  • Freeciv21 version: current master (4c6aee6)
  • Ruleset/Longturn game (if applicable): not applicable

Additional context
No additional context
@daavko daavko added bug Something isn't working Untriaged This issue or PR needs triaging labels Jul 13, 2022
@jwrober jwrober added gui This issue requires changes to the user interface and removed Untriaged This issue or PR needs triaging labels Jul 13, 2022
@jwrober
Copy link
Collaborator

jwrober commented Jul 13, 2022

Interesting bug since you can't actually see the mini-map when in city view, but if you use ctrl-m while in city view the bug asserts itself. Seems like an edge case to me.

@lmoureaux lmoureaux mentioned this issue Aug 13, 2022
Open
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 26, 2022
@lmoureaux
Forbid toggling the minimap from the city view
30e14f5 
It's never visible, so the menu would do nothing. The implementation is also
buggy when triggered while the widget is hidden.

Closes longturn#1126.
@lmoureaux lmoureaux mentioned this issue Aug 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working gui This issue requires changes to the user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Forbid toggling the minimap from the city view lmoureaux/freeciv21
2 participants
@daavko @jwrober