Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horizontal lines in the research tree aren't completely horizontal #1091

Closed
daavko opened this issue Jul 7, 2022 · 1 comment · Fixed by #1105
Closed

Horizontal lines in the research tree aren't completely horizontal #1091

daavko opened this issue Jul 7, 2022 · 1 comment · Fixed by #1105
Assignees
@lmoureaux
Labels
bug Something isn't working gui This issue requires changes to the user interface

Comments

@daavko
Copy link
Collaborator

daavko commented Jul 7, 2022

Describe the bug
They should be straight lines, but they bob up and down by a pixel.

To Reproduce
Steps to reproduce the behavior:

  1. Open the research tree
  2. Observe non-straight lines

Expected behavior
Straight lines

Screenshots
In the middle of the magenta rectangle here
freeciv21-client_P8839TL9fo

Platform and version (please complete the following information):

  • OS: Windows 10
  • Freeciv21 version: beta 2
  • Ruleset/Longturn game (if applicable): not applicable

Additional context
No additional context
@daavko daavko added bug Something isn't working Untriaged This issue or PR needs triaging labels Jul 7, 2022
@psampathkumar psampathkumar added gui This issue requires changes to the user interface and removed Untriaged This issue or PR needs triaging labels Jul 9, 2022
@lmoureaux lmoureaux self-assigned this Jul 9, 2022
@lmoureaux
Copy link
Contributor

Confirmed

lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Jul 9, 2022
@lmoureaux
Fix line alignment in the tech tree
8c55953 
Lines are drawn with a 2px width, and we must take this into account in the
position of their starting point.

Closes longturn#1091.
@lmoureaux lmoureaux mentioned this issue Jul 9, 2022
Merged
psampathkumar pushed a commit that referenced this issue Jul 9, 2022
@lmoureaux @psampathkumar
Fix line alignment in the tech tree
0a679cd 
Lines are drawn with a 2px width, and we must take this into account in the
position of their starting point.

Closes #1091.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmoureaux lmoureaux

Labels
bug Something isn't working gui This issue requires changes to the user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix line alignment in the tech tree lmoureaux/freeciv21
3 participants
@daavko @lmoureaux @psampathkumar