Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check legality of unit actions on adjacent tiles on tile change #1064

Closed
psampathkumar opened this issue Jun 26, 2022 · 0 comments · Fixed by #2466
Closed

Check legality of unit actions on adjacent tiles on tile change #1064

psampathkumar opened this issue Jun 26, 2022 · 0 comments · Fixed by #2466
Assignees
@lmoureaux
Labels
bug Something isn't working port-from-freeciv This was implemented in Freeciv server This issue requires changes to the server

Comments

@psampathkumar
Copy link
Contributor

Describe the bug
There's a long standing issue with typical rulesets where legality of the irrigating activity can depend on the irrigation of the adjacent tile. If that adjacent tile loses the irrigation for some reason, we later get an error about unit doing illegal activity.

To Reproduce

  1. Irrigate a tile
  2. If neighbouring tile loses irrigation during TC, due to some reason you get an error for illegal behaviour

Expected behavior
Check in advance, so there is no illegal behaviour

Screenshots
If applicable, add screenshots to help explain your problem.

Platform and version (please complete the following information):
master

Additional context
Port freeciv/freeciv@15d2746
@psampathkumar psampathkumar added bug Something isn't working server This issue requires changes to the server port-from-freeciv This was implemented in Freeciv labels Jun 26, 2022
@lmoureaux lmoureaux self-assigned this Dec 23, 2024
This was referenced Dec 23, 2024
Closed
Open
lmoureaux pushed a commit to lmoureaux/freeciv21 that referenced this issue Dec 23, 2024
@cazfi @lmoureaux
Climate change: Check unit activities on tiles surrounding changed one
f365d68 
See osdn #44155
Closes longturn#1064.

Signed-off-by: Marko Lindqvist <[email protected]>
@lmoureaux lmoureaux mentioned this issue Dec 23, 2024
Merged
lmoureaux pushed a commit to lmoureaux/freeciv21 that referenced this issue Dec 23, 2024
@cazfi @lmoureaux
Climate change: Check unit activities on tiles surrounding changed one
904ec30 
See osdn #44155
Closes longturn#1064.

Signed-off-by: Marko Lindqvist <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmoureaux lmoureaux

Labels
bug Something isn't working port-from-freeciv This was implemented in Freeciv server This issue requires changes to the server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Climate change: Check unit activities on tiles surrounding changed one lmoureaux/freeciv21
2 participants
@lmoureaux @psampathkumar