Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove infra points #18

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

blabber
Copy link
Contributor

@blabber blabber commented Feb 17, 2024

Support for infra points has been removed from Freeciv21 (longturn/freeciv21#1937).

I noticed this while trying to load LTT and LTX in the latest Freeciv21 client as a single player game. However, loading the ruleset still fails, probably because of these messages:

[warning] freeciv21-client - The server sent an invalid or unknown requirement.
[warning] freeciv21-client - The server sent an invalid or unknown requirement.

Support for infra points has been removed from Freeciv21
(longturn/freeciv21#1937)
@lmoureaux
Copy link
Contributor

Just to clarify, does loading the ruleset still fail after this commit?

@lmoureaux lmoureaux merged commit be62af9 into longturn:master Feb 17, 2024
@blabber
Copy link
Contributor Author

blabber commented Feb 17, 2024

Yes, in latest it still fails.

@blabber
Copy link
Contributor Author

blabber commented Feb 17, 2024

Closed #15.

Regarding the persistent failure to load LTT/LTX in latest: neither stderr, nor the server output in the client, give a hint at a possible cause.

Looking at the code, the warnings I mentioned above, should not cause errors while loading the ruleset.

@blabber blabber deleted the feature/remove_infra_points branch February 17, 2024 23:35
@lmoureaux
Copy link
Contributor

Server stderr does give a hint, I'm fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants