Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid multiple babel-polyfill loaded #14

Closed

Conversation

logankoester
Copy link

@logankoester logankoester commented Sep 28, 2016

An error is thrown if a process attempts to load babel-polyfill more than once:

ERROR in only one instance of babel-polyfill is allowed.

See shakacode/bootstrap-loader#16

An error is thrown if a process attempts to load babel-polyfill more
than once:

`ERROR in only one instance of babel-polyfill is allowed`.

See shakacode/bootstrap-loader#16

Signed-off-by: Logan Koester <[email protected]>
@clayne11
Copy link
Collaborator

clayne11 commented Oct 6, 2016

This is actually not the right approach. A library should never provide the babel-polyfill at all. It can cause certain runtime environments to break such as Meteor.

This will emulate a full ES2015 environment and is intended to be used in an application rather than a library/tool.

(emphasis mine)

See https://babeljs.io/docs/usage/polyfill/

@aldeed
Copy link
Collaborator

aldeed commented Dec 23, 2016

I agree we should remove the dependency. I can't remember what it was needed for, so might need to keep it as a peer dependency or rewrite whatever code relies on it.

@aldeed
Copy link
Collaborator

aldeed commented Dec 26, 2016

Removed this dependency in 29c6d9f

@aldeed aldeed closed this Dec 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants