Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mutlipe backup targets on UI #755

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

a110605
Copy link
Contributor

@a110605 a110605 commented Jun 18, 2024

What this PR does / why we need it

Support mutlipe backup targets feature in longhorn UI

Longhorn UI change Items

  • Backup & backup detail page should display correctly since some API schemes changed
  • Add new page in Settings -> Backup Target
    - Display all backup targets in a table
    - Allow user to create new backup target
    - delete / edit existing item
    - bulk delete
    - filter backup target on page top right
  • allow user to choose backup target when creating backup task recurring job.
  • allow user to choose backup target when creating backup in volume detail page.
  • allow user to choose backup target when creating backup backing image
  • Disable create backup in volume detail / backup / system backup pages if no available and writable backup targets

Note. This UI PR need to wait for longhorn-manager and LEP PRs merge first.

Issue

[UI][FEATURE] Multiple backup stores support

Test Result

Backup detail page should display correct backups (the backup belongs to that backup target)
image

CRUD operations in Settings -> Backup Target page

backuptarget-crud.mov

Allow user to choose backup target when creating backup task recurring job.

recurring-job.mov

Allow user to choose backup target when creating backup in volume detail page

volume-create-backup.mov

Allow user to choose backup target when creating backup backing image

backingimagebackup.mov

Additional documentation or context

@a110605 a110605 self-assigned this Jun 18, 2024
@a110605 a110605 changed the title Issue 8647 Support mutlipe backup targets on UI Jun 18, 2024
@a110605 a110605 changed the title Support mutlipe backup targets on UI Support mutlipe backup targets on UI (Testing...) Jun 18, 2024
@a110605 a110605 changed the title Support mutlipe backup targets on UI (Testing...) Support mutlipe backup targets on UI (testing...) Jun 18, 2024
@a110605 a110605 requested a review from a team June 18, 2024 08:58
@a110605 a110605 force-pushed the issue-8647 branch 2 times, most recently from 2b4a68d to 9d59bf2 Compare June 19, 2024 07:54
@a110605 a110605 changed the title Support mutlipe backup targets on UI (testing...) Support mutlipe backup targets on UI Jun 19, 2024
Copy link

mergify bot commented Jul 2, 2024

This pull request is now in conflict. Could you fix it @a110605? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant