Fix csi resizer timeout param usage #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using a really old csi resizer image, that doesn't yet support the new `timeout` param, instead it relies on an old `csiTimeout` param. Decided against updating the csi images and instead will do a full update of all the csi images for 1.2. See kubernetes-csi/external-resizer#82 Longhorn longhorn#2347 Signed-off-by: Joshua Moody <[email protected]>
yasker
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using a really old csi resizer image, that doesn't yet support the
new
timeoutparam, instead it relies on an oldcsiTimeoutparam.Decided against updating the csi images and instead will do a full update
of all the csi images for 1.2.
See kubernetes-csi/external-resizer#82
longhorn/longhorn#2347
Signed-off-by: Joshua Moody [email protected]