Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backup): do not get backing image custom resource #3372

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix(backup): do not get backing image custom resource #3372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions webhook/resources/backupbackingimage/validator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ func (bbi *backupBackingImageValidator) Create(request *admission.Request, newOb
backingImageName := backupBackingImage.Spec.BackingImage

backingImage, err := bbi.ds.GetBackingImageRO(backingImageName)
if err != nil {
if err != nil && !datastore.ErrorIsNotFound(err) {
return werror.NewInvalidError(fmt.Sprintf("failed to get the backing image %v for backup: %v", backingImageName, err), "")
}
// TODO: support backup for v2 data engine in the future
if types.IsDataEngineV2(backingImage.Spec.DataEngine) {
if backingImage != nil && types.IsDataEngineV2(backingImage.Spec.DataEngine) {
return werror.NewInvalidError(fmt.Sprintf("backing image %v uses v2 data engine which doesn't support backup operations", backingImageName), "")
}

Expand Down
Loading