Send a reminder email to users whose subscriptions are about to lapse. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue londonhackspace#60 on the Hackspace repository: londonhackspace#60 It also refactors the email-sending code for reusability, and includes a database schema change so we only send people a maximum of one reminder email per month.
Fix typos on LDAP settings page
Conflicts: etc/schema.sql
|
I'm going to combine this with #138 next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #60 on the Hackspace repository. It sends users whose subscriptions are about to lapse a gentle(ish) reminder, before they get unsubscribed a few days later.
I've tested this code a little, and it's very closely based on the existing code to unsubscribe users, but I don't have access to live or test data. I'd recommend more testing before putting it into production.
It also refactors the email-sending code for reusability, and includes a database schema change so we only send people a maximum of one reminder email per month. This means we can run the task regularly from a cron job without worries of spamming people over and over again.