Merge pull request openhab#3 from lolodomo/sonnen_SonnenJSONCommunica…

…tion Fix handling of batteryData
lolodomo · Jan 8, 2022 · 47733e0 · 47733e0
2 parents 27f2970 + 9aa4ebf
commit 47733e0
Showing 1 changed file with 13 additions and 18 deletions.
diff --git a/...onnen/src/main/java/org/openhab/binding/sonnen/communication/SonnenJSONCommunication.java b/...onnen/src/main/java/org/openhab/binding/sonnen/communication/SonnenJSONCommunication.java
@@ -23,6 +23,7 @@
 import org.slf4j.LoggerFactory;
 
 import com.google.gson.Gson;
+import com.google.gson.JsonSyntaxException;
 
 /**
  * This class handles the JSON communication with the sonnen battery
@@ -41,7 +42,6 @@ public class SonnenJSONCommunication {
 
     public SonnenJSONCommunication() {
         gson = new Gson();
-        batteryData = new SonnenJsonDataDTO();
         config = new SonnenConfiguration();
     }
 
@@ -53,28 +53,24 @@ public SonnenJSONCommunication() {
      * @return true if no error occurred, false otherwise.
      */
     public boolean refreshBatteryConnection(Helper message, String thingUID) {
-        SonnenJsonDataDTO result = null;
         boolean resultOk = false;
-        String errorDetail = "", statusDescr = "";
+        String statusDescr = "";
         String urlStr = "http://" + config.hostIP + "/api/v1/status";
 
-        String response = null;
         try {
-            response = HttpUtil.executeUrl("GET", urlStr, 10000);
+            String response = HttpUtil.executeUrl("GET", urlStr, 10000);
             logger.debug("BatteryData = {}", response);
-            result = gson.fromJson(response, SonnenJsonDataDTO.class);
+            if (response == null) {
+                throw new IOException("HttpUtil.executeUrl returned null");
+            }
+            batteryData = gson.fromJson(response, SonnenJsonDataDTO.class);
             resultOk = true;
-        } catch (IOException e) {
+        } catch (IOException | JsonSyntaxException e) {
             logger.debug("Error processiong Get request {}", urlStr);
-            statusDescr = "Cannot find service on given IP" + config.hostIP + " Please verify the IP-Address!";
-            errorDetail = e.getMessage();
+            batteryData = null;
+            statusDescr = "Cannot find service on given IP " + config.hostIP + ". Please verify the IP address!";
             resultOk = false;
-        }
-        if (resultOk) {
-            batteryData = result;
-        } else {
-            logger.debug("Setting thing '{}' to OFFLINE: Error '{}'", thingUID, errorDetail);
-            batteryData = new SonnenJsonDataDTO();
+            logger.debug("Setting thing '{}' to OFFLINE: Error '{}'", thingUID, e.getMessage());
         }
         message.setStatusDescription(statusDescr);
         return resultOk;
@@ -92,10 +88,9 @@ public void setConfig(SonnenConfiguration config2) {
     /**
      * Returns the actual stored Battery Data
      *
-     * @return JSON Data from the Battery
+     * @return JSON Data from the Battery or null if request failed
      */
-    @Nullable
-    public SonnenJsonDataDTO getBatteryData() {
+    public @Nullable SonnenJsonDataDTO getBatteryData() {
         return this.batteryData;
     }
 }